AOSSIE-Org / AOSSIE-Org/DebateAI

Concede message shown incorrectly + pre-existing ESLint errors in OnlineDebateRoom.tsx

Open
#344 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
84
Forks
198
Avg merge
2d 19h
Merged PRs (30d)
30

Description

When a user concedes the debate, both users receive "You win!" due to the WebSocket concede event being broadcast to all participants without checking who was the sender. Additionally, the file had 13 pre-existing ESLint errors including unused variables, empty catch blocks, and implicit any types.

Screenshot:
Image

Steps to Reproduce:
Open a debate room in two browsers
One user clicks Concede
Both users incorrectly see "You win! "

Expected Behavior: Only the opponent should see "You win!". The conceding user should see "You have conceded."

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.