merge _prob_params and Castro's _cpp_parameters

Open
#2,686 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
build-system

Research direction

Start by comparing the make rule and generation mechanism for the problem's _prob_params file with the process for Castro's _cpp_parameters. Trace how the main Castro parameters are generated and consumed, then check issue #2685 for the intended follow-up; done means both parameter types use one consistent process without breaking existing builds.

Written by the indexing model from the issue text.

Description

clean-up

Right now, we have a different make rule / mechanism for generating the problem parameters (looking that the problem's _prob_params file) than we do for all of the other Castro parameters. The parameter files are basically the same, so we should just merge this into a single process, all handled by the main Castro parameters.

This will make #2685 easier

Dominant language
C++
Stars
340
Forks
105
Avg merge
3d 8h
Merged PRs (30d)
8

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AMReX-Astro/Castro

All issues in AMReX-Astro/Castro

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.