AMDEPYC / AMDEPYC/sev-certify

sev-verify: Pass parameters to callable steps

Abierto
#305 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
Python
Estrellas
3
Forks
7
Merge medio
1 d 21 h
PR fusionados (30 d)
8

Descripción

Follow-up from [PR #283](https://github.com/AMDEPYC/sev-certify/pull/283) - [(review thread from @DGonzalezVillal on `snphost_config_commit.py`)](https://github.com/AMDEPYC/sev-certify/pull/283#pullrequestreview-4986631251).

Callable steps are dispatched by name with no arguments other than the shared `StepContext`. This results in multiple function wrappers for the same function when called from a step. Enable passing parameters so functions may be called directly.

### Suggested Solution
- Add an optional `params: dict` (or similar) to the callable step definition (`BaseStep` / `Step.for_callable` in `sev_verify/models.py`).
- In `run_callable_step` (`sev_verify/runner.py`), pass those params to the handler - e.g. `fn(ctx, **params)` or via a field on `StepContext`, keeping the no-arg form working for existing handlers.

Then collapse the duplicated handlers into single parameterized functions, e.g.
one `verify_guest_report(ctx, *, report, expect_match_reported)`.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.