AI4Finance-Foundation / AI4Finance-Foundation/FinRL-Tutorials

FinRL_MultiCrypto_Trading.py no longer working due to changes in ElegantRL and FinRL-Meta

Open
#61 1 comment 3 reactions 0 assignees View on GitHub
bug
Dominant language
Jupyter Notebook
Stars
1.2k
Forks
435
PR merge metrics
No merged PRs in 30d

Description

Hi, there is quite a lot broken in the current version of FinRL_MultiCrypto_Trading.ipynb

See: https://github.com/AI4Finance-Foundation/FinRL-Meta/issues/291
Also see: #21

I am able to go around many of the problems by running old versions of the repos/dependencies but in the end i failed.
As mentioned in one of the urls. Since Jan 2023 ElegantRL is no longer compatible.

/FinRL-Meta/agents/elegantrl_models.py is also no longer compatible due to line 58 (and more) changing Arguments(agent=agent, env=env) to Arguments(agent_class=agent, env=env)

ray.rllib also seems to have had some breaking changes. Also tried version 2.0.0 since its from around date the tutorial was moved into this repo but still didn't work.

Please fix the tutorials. I realy would like to get started looking into FinRL.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.