AI4Finance-Foundation / AI4Finance-Foundation/FinRL-Tutorials

Question about actions = actions / closings in StockTradingEnvV2.step() (tutorial_this_works_1_18.ipynb)

Open
#107 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
1.2k
Forks
435
PR merge metrics
No merged PRs in 30d

Description

Hello AI4Finance team,

First of all, thank you for providing the excellent tutorials and open-source implementations in FinRL — they are very helpful for reinforcement learning applications in finance!

I have a question regarding the notebook:
📍 FinRL-Tutorials/5-Others/tutorial_this_works_1_18.ipynb
Specifically in:
Part 5. Design Environment → class StockTradingEnvV2(gym.Env)

In the step(self, actions) function, I noticed the following line:
"actions = actions / closings"

Could you kindly explain the purpose of this line?

Is it intended to normalize the action values by the stock's closing prices?

Or does it serve a different function related to position sizing, portfolio allocation, or transaction cost handling?

I’d appreciate any clarification you could provide.

Thank you so much again for your amazing work!

Best regards

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.