AI4Finance-Foundation / AI4Finance-Foundation/ElegantRL
Suggestion: AgentXXX.py if_act_target if_cri_target
- Dominant language
- Python
- Stars
- 4.4k
- Forks
- 978
- PR merge metrics
- No merged PRs in 30d
Description
There are bug in `if_act_target` and `if_cri_target` in `AgentBase.py`
`class AgentXXX.__init__()` should set `args.if_cri_target = getattr(self, "if_cri_target", True)` (or False) in default.
Takes AgentDQN as an example, the following code should be changed.
https://github.com/AI4Finance-Foundation/ElegantRL/blob/3ded1cef5d9c9100422935141b07d3ec5301db4b/elegantrl/agents/AgentDQN.py#L21-L26
Change to fhe following code (as `ElegantRL HelloWorld` version do):
https://github.com/AI4Finance-Foundation/ElegantRL/blob/3ded1cef5d9c9100422935141b07d3ec5301db4b/elegantrl_helloworld/agent.py#L62-L69
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.