AI4Finance-Foundation / AI4Finance-Foundation/Dynamic-Stock-Recommendation-Machine_Learning-Published-Paper-IEEE

A potential bug in portfolio optimization?

Abierto
#2 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Jupyter Notebook
Estrellas
23
Forks
20
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

in your fundamental_portfolio.ipynb, under **"4. Potfolio Optimization using pypfopt"**, you have this two lines
` p1_return_table_pivot=p1_return_table.pivot_table(index = 'datadate',columns = 'tic', values = 'daily_return')`
` S = risk_models.sample_cov(p1_return_table_pivot)`
I think you should use
`S = risk_models.sample_cov(p1_return_table_pivot,returns_data=True)`

I am reading the documentation, sample_cov assumes the first argument to be price data rather than returns. you will have to specify returns_data=True in this case, since you're using return data directly? (let me know if I got it wrong)
https://pyportfolioopt.readthedocs.io/en/latest/RiskModels.html?highlight=sample_cov#pypfopt.risk_models.sample_cov

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.