AI-Hypercomputer / AI-Hypercomputer/xpk

xpk should fail fast if a JobSet or PathwaysJob will result in an invalid value for the `jobset.sigs.k8s.io/coordinator` label

未关闭
#750 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
193
派生
94
平均合并
24 分钟
30 天内合并 PR
1

描述

JobSet's admission webhook now rejects requests to create JobSet objects that would result in an invalid value for the `jobset.sigs.k8s.io/coordinator` label. In most cases, this is equivalent to limiting the length of the JobSet name when the coordinator feature is enabled. See https://github.com/kubernetes-sigs/jobset/issues/1056 and https://github.com/kubernetes-sigs/jobset/pull/1079.

Following this fail-fast principle, xpk should also preemptively fail commands that would lead to this invalid state.

For xpk commands that create a JobSet object directly, the error from the JobSet admission webhook can likely just be bubbled up to the user.

The core problem arises when xpk creates a PathwaysJob object. Since the PathwaysJob controller does not have an admission webhook, the creation request succeeds. However, the PathwaysJob controller will then try to create a child JobSet at runtime and continuously fail because the JobSet webhook will block the invalid request. This results in a confusing, difficult-to-debug failure loop for the user, as the initial xpk command appeared to succeed.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。