AI-Hypercomputer / AI-Hypercomputer/xpk

[slice] e2e tests still passing after removing health label

Aberta
#614 14 comentários 0 reações 1 responsável Reivindicada por @mbobrovskyi Ver no GitHub
Linguagem predominante
Python
Estrelas
193
Forks
94
Merge médio
24min
PRs com merge (30d)
1

Descrição

We annotate each replicated job in JobSet here: https://github.com/AI-Hypercomputer/xpk/blob/1d2ac6b4d1e896cbd0ffde3781e0067a6ffd2812/slice/internal/webhooks/jobset_webhook.go#L66

However, after deletion/modification of the label used in e2e test, the tests still pass. Remove this line: https://github.com/AI-Hypercomputer/xpk/blob/1d2ac6b4d1e896cbd0ffde3781e0067a6ffd2812/slice/hack/kind-cluster.yaml#L30

And observe e2e tests still pass. Kueue should not return topology assignments on such nodes for these replicated jobs, which require this NodeLabel

**Additional Info**
Modifying the [loop](https://github.com/kubernetes-sigs/kueue/blob/b44cf15a52b5c97d46d172dcf2432228bd03403e/pkg/util/testingjobs/jobset/wrappers.go#L79) which creates each replicated job to add a node selector:
```
jt.Spec.Template.Spec.NodeSelector = map[string]string{"hello": "world"}
```
Results in Kueue's e2e tests failing. So, it seems that Kueue/TAS is acting upon these node selectors in some way. This makes me think that this is more likely a Slice Controller issue.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.