AI-Hypercomputer / AI-Hypercomputer/maxtext

Fix "~/xpk" references

未關閉
#1,561 7 則留言 0 個 reaction 已指派 1 人 已被 @bvandermoon 認領 在 GitHub 檢視
bug
主要語言
Python
星號
2.4k
分支
607
平均合併
2 天 19 小時
30 天內合併 PR
158

描述

I tried making it `os.path.join(os.path.expanduser("~"), "directory")` in one of my earlier commits but that doesn't work. Explicitly someone made a mistake earlier on by not expanding `~` with [`os.path.expanduser`](https://docs.python.org/3/library/os.path.html#os.path.expanduser) so it actually expects in the maxtext directory a folder named `~` with the `xpk` folder inside. Otherwise the tests fail on CI.

_Originally posted by @SamuelMarks in https://github.com/AI-Hypercomputer/maxtext/pull/1560#discussion_r2037944071_

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。