AI-Hypercomputer / AI-Hypercomputer/maxtext

Apparent bug in the megablocks implementation

Aperta
#1,183 14 commenti 2 reazioni 1 assegnatario Rivendicata da @RissyRan Vedi su GitHub
Lingua principale
Python
Stelle
2.4k
Fork
607
Merge medio
2g 19h
PR unite (30g)
158

Descrizione

Hello,

Firstly, thank you very much for providing us with a great industry-grade LLM training library.

I've noticed that when `megablox=True`, the logits do not match those of the Huggingface implementation: [link to the specific code](https://github.com/AI-Hypercomputer/maxtext/blob/main/end_to_end/tpu/mixtral/8x7b/2_test_mixtral.sh#L46).

Additionally, when fine-tuning from the mixtral checkpoint, the loss begins higher than expected but rapidly decreases. However, the resulting model weights, when converted back to the Huggingface format, perform poorly on MMLU.

Conversely, when `sparse_matmul=True` and `megablox=False`, the loss starts at a lower level and the resulting Huggingface-converted model performs well on MMLU. Nevertheless, the MFU is approximately 3 times lower with `ragged_dot` than with `megablox`, making training impractical at larger scales.

Are there any plans to address these discrepancies in the implementation?

Best regards.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.