AI-Hypercomputer / AI-Hypercomputer/maxtext

Why logit checker has such a high tolerance?

未關閉
#1,021 0 則留言 4 個 reaction 已指派 1 人 已被 @gagika 認領 在 GitHub 檢視
主要語言
Python
星號
2.4k
分支
607
平均合併
2 天 19 小時
30 天內合併 PR
158

描述

Hi, I would like to understand why the comparison with the golden logits uses high absolute tolerance values, such as:

- `--atol=3` for [Mistral-7b](https://github.com/AI-Hypercomputer/maxtext/blob/1ff8505cb2c9fb5abd65de73cf3d9b70cec20890/end_to_end/tpu/mistral/7b/test_mistral-7b.sh#L42)
- `--atol=1.0` for [Gemma2-9b](https://github.com/AI-Hypercomputer/maxtext/blob/1ff8505cb2c9fb5abd65de73cf3d9b70cec20890/end_to_end/tpu/gemma2/9b/2_test_gemma.sh#L47)

while some models achieve more similar results with smaller tolerances:
- `--atol=0.2` for [Llama-2-70b](https://github.com/AI-Hypercomputer/maxtext/blob/1ff8505cb2c9fb5abd65de73cf3d9b70cec20890/end_to_end/tpu/llama2/70b/2_test_llama2_70b.sh#L63C53-L63C63)

Why is this high tolerance needed? I understand we might expect numerical differences, but I was hoping for more similar results when implementations are equivalent.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。