ADORSYS-GIS / ADORSYS-GIS/lightbridge-authz

[Ticket]: Add a SOLID/DRY reviewer checklist to the PR template

未关闭 适合新手
#518 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
documentation ticket
主要语言
Rust
星标
0
派生
1
平均合并
7 小时 7 分钟
30 天内合并 PR
237

描述

### Type
Technical debt

### Summary
Extend the PR template with the specific review questions the linter cannot answer.

### Intent
So review attention lands on failure modes and ownership shape rather than on formatting the linter already enforces.

### Source of truth (links)
- `AGENTS.md`, 'Spend review attention here instead'
- https://adorsys-gis.github.io/ai-governance/04-pull-request-template

### Current Behavior
The template carries governance sections but no design-quality prompts.

### Expected Behavior
Reviewers are asked the five questions that have actually caught bugs here.

### Acceptance Criteria
- [ ] Checklist covers: fail-closed behaviour, ownership/cloning, error-type levels, whether tests would fail if logic were wrong, and locks held across `.await`
- [ ] Existing governance sections are preserved unchanged
- [ ] Each item asks for a MECHANISM, not a verdict

### Out of Scope
Automated enforcement of any of it.

### Technical Context
The first question is the highest-yield one in this repo: does the unavailable branch become the permissive branch?

### Risks
A long checklist gets skimmed. Keep it to five items.

### Test Plan
Apply to one real PR and confirm the prompts produce concrete comments.

### Verification evidence
- [ ] Test added and proven to fail before the change
- [ ] `just all-checks` green
- [ ] Every new or changed `src` file is <= 200 LoC

### Human accountable owner
@stephane-segning

### AI Usage Declaration
Ticket drafted with AI assistance from a verified repo audit.
Structure and estimates drafted with AI from a verified repository audit (file
line counts, config keys, and dependency state were read from the actual tree,
not assumed). A human owns intent, scope, and the release commitment.

### Human verification completed
- [ ] I can explain this work without referring to the AI-generated text
- [ ] Acceptance criteria are testable
- [ ] Source of truth is a real link, not boilerplate

Governance: https://adorsys-gis.github.io/ai-governance/

贡献指南

打开贡献指南

调研方向

Start with AGENTS.md, especially 'Spend review attention here instead', and the linked pull-request-template page. Find the repository PR template and add only the five requested mechanism-focused questions while preserving existing governance sections. Done means the checklist matches the acceptance criteria, has been tried on one real PR, and `just all-checks` is green.

由索引模型根据 Issue 内容生成。

评估

技术栈
github, rust
领域
developer-experience, documentation
Issue 类型
文档
难度
2/5
预计耗时
1-3 小时
活跃度
活跃
描述清晰度
描述清楚
新手友好度
78/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。