ADORSYS-GIS / ADORSYS-GIS/keycloak-oid4vp-plugin
Deduplicate wallet attestation validation code
- 主要语言
- Java
- 星标
- 35
- 派生
- 1
- 平均合并
- 2 天 9 小时
- 30 天内合并 PR
- 17
描述
Class `WalletAttestationValidator` appears to duplicate code already existing in upstream Keycloak for the same purpose.
Investigate and reuse instead.
https://github.com/ADORSYS-GIS/keycloak-oid4vp-plugin/blob/7a9bbe2c0fb5052bf01dc17812ba21d2378ec116/src/main/java/io/github/adorsysgis/keycloak/protocol/oid4vc/presentation/WalletAttestationValidator.java#L52-L58
ETA: 2 days
贡献指南
这个仓库没有索引到贡献指南
调研方向
Start in src/main/java/io/github/adorsysgis/keycloak/protocol/oid4vc/presentation/WalletAttestationValidator.java, especially lines 52-58, and compare the validation code with the corresponding upstream Keycloak implementation. Confirm whether the upstream code can be reused without changing wallet-attestation behavior, then run the project's existing tests to verify the refactor.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- java
- 领域
- authentication
- Issue 类型
- 重构
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 活跃
- 描述清晰度
- 基本清楚
- 新手友好度
- 25/100