ACI-Rental / ACI-Rental/front-end

Fix problems in 'view catalog'

未关闭
#31 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug good first issue
主要语言
TypeScript
星标
0
派生
4
PR 合并指标
30 天内没有已合并 PR

描述

Add catalog tests

![image](https://user-images.githubusercontent.com/14212955/120629333-01bffe00-c466-11eb-8579-78e251f6daf0.png)
Keep pagination at bottom at all times

![image](https://user-images.githubusercontent.com/14212955/120629384-0d132980-c466-11eb-950f-db308e76cbca.png)
Images jump when changing

![image](https://user-images.githubusercontent.com/14212955/120629488-25834400-c466-11eb-9e2e-6f9a8c27c9bd.png)
When screen is too small, the datapicker gets out of view

datepicker-unavailable is atm not well constructed (we discussed in discord), has a bug.
But the fact that this bug was not found during the creation of the unit tests actually says that the unit tests are not good / not pulled well enough. Try to apply only 1 change per test (so don't apply status EN requiresApproval in one test, for example, but really separate test for writing, and possibly another test where both change or something)

Also, ARCHIVED does not work. Would not eg not 'temporarily unavailable' but 'this product is permanently unavailable' or something, indicate that it will never be available again. (filed is miss not clear enough)

See https://github.com/SieBrum/aci-frontend/pull/30 for more information

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。