99designs / 99designs/http-signatures-php
Use hash_equals instead of double HMAC approach for signature comparison
Aperta
- Lingua principale
- PHP
- Stelle
- 46
- Fork
- 35
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
See https://github.com/99designs/http-signatures-php/pull/28 for what prompted this.
We're currently using a double HMAC approach for signature comparison, as that was the only way for us to securely compare HMAC signatures without making it a breaking change, as the [hash_equals](https://secure.php.net/hash_equals) function we need isn't available until PHP 5.7, and we support PHP 5.5+
When we roll out our next major version we should increase the minimum PHP version to 5.7 or higher, and swap to using `hash_equals`.
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.