99designs / 99designs/http-signatures-php

Use hash_equals instead of double HMAC approach for signature comparison

Open
#29 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
46
Forks
35
PR merge metrics
No merged PRs in 30d

Description

See https://github.com/99designs/http-signatures-php/pull/28 for what prompted this.

We're currently using a double HMAC approach for signature comparison, as that was the only way for us to securely compare HMAC signatures without making it a breaking change, as the [hash_equals](https://secure.php.net/hash_equals) function we need isn't available until PHP 5.7, and we support PHP 5.5+

When we roll out our next major version we should increase the minimum PHP version to 5.7 or higher, and swap to using `hash_equals`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.