99designs / 99designs/gqlgen

Directives with ":" in value generate incorrect go tags

未关闭 适合新手
#2,766 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Go
星标
10.8k
派生
1.3k
平均合并
2 天 36 分钟
30 天内合并 PR
26

描述

### What happened?
I declare a directive for custom go tags (in `schema.directives.gql`):

```
directive @goTag(
key: String!
value: String
) on INPUT_FIELD_DEFINITION | FIELD_DEFINITION
```

Then I use it the following way :
```
type Value {
value: Float!
unit: String!
}

type Order {
name: String! @goTag(key: "gorm", value: "primaryKey")
amount: Value! @goTag(key: "gorm", value: "embedded;embeddedPrefix:dissolutionAmount_")
submitterRef String!
submitter: Person! @goTag(key: "gorm", value: "foreignKey: SubmitterRef")
}

```

Then I run code generation: `go run github.com/99designs/gqlgen generate` and the resulting code contains gorm tags that cut out text after colon:

```
type Order struct {
Name string `json:"name" gorm:"primaryKey"` // <--- this is correct
Amount Value `json:"amount" gorm:"embedded;embeddedPrefix` // INCORRECT - everything after "embeddedPrefix" is truncated: ":dissolutionAmount_" is missing, including trailing double quote
SubmitterRef string. `json:"submitterRef"`
Submitter Person `json:"submitter" gorm:"foreignKey` // INCORRECT - value in gorm tag is truncated, ": SubmitterRef" is missing
}
```

### What did you expect?
I expect the generated go code to include the correct gorm tags in the respective fields:
```
type Order struct {
Name string `json:"name" gorm:"primaryKey"`
Amount Value `json:"amount" gorm:"embedded;embeddedPrefix:dissolutionAmount_"`
SubmitterRef string. `json:"submitterRef"`
Submitter Person `json:"submitter" gorm:"foreignKey:SubmitterRef"`
}
```

### Minimal graphql.schema and models to reproduce

### versions
- `go run github.com/99designs/gqlgen version`? v0.17.34
- `go version`? v1.21.0

贡献指南

打开贡献指南

调研方向

查看指令的代码生成部分,可能位于 codegen/ 或 plugin/ 中。问题在于,生成 Go struct tag 时,指令值中的冒号被错误地解析或转义了。先搜索 'goTag' 或指令处理逻辑。运行提供的示例以复现 bug,然后检查 tag 字符串是如何组装的。修复应确保完整的值保留在生成的 tag 中。

由索引模型根据 Issue 内容生成。

评估

技术栈
go, graphql
领域
backend
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
65/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。