99designs / 99designs/gqlgen

[RFC] Option in config to have return values based on schema nullability

Open
#1,393 8 comments 10 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
10.8k
Forks
1.3k
Avg merge
2d 36m
Merged PRs (30d)
26

Description

### What happened?

In #375 we discussed and changed the resolvers return from this:

for `query { user: User! }` we generate `func (r *Query) User(ctx context.Context) (User, error)`
for `query { user: User }` we generate `func (r *Query) User(ctx context.Context) (*User, error)`

to always this:

`query { user: User }` ---> `func (r *Query) User(ctx context.Context) (*User, error)`

### What did you expect?

To have in config something like: `omit_slice_element_pointers: false` (for slices) to have not pointer return values for resolvers.

Does it make sense or am I wrong?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.