9001 / 9001/copyparty

Opinion of ufavico's and favico's function.

未关闭
#898 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
46.6k
派生
1.9k
平均合并
10 天 16 小时
30 天内合并 PR
5

描述

# Question regarding the favicons

As it stands now (and working perfectly as intended)

## If `--ufavico` is set in config (Global or Per Volume) and `--favico` is set to empty

Everything works as one would expect it to work, the favicon automatically changes on navigation to the set value.

## If `--ufavico` is not used and `--favico` is set in config or by user

As expected the `--favico` is used for every page of copyparty.

## If `--ufavico` is set in config (Global or Per Volume) and `--favico` is set to empty, but the user sets it to some value

Since the interface allows for a user to set the value of `--favico` if beyond that the `--ufavico` is set as well the user set `--favico` takes precedence, except if we reload with Ctrl+F5. In that case the `--ufavico` may be shown.

## Question

Would it not be better for these scenarios to make `--ufavico` take precedence over `--favico` if one exists for the volume; and in this case if `--ufavico` is set as a global value, the `--favico` in the settings could not be used at all to take effect, so might as well be hidden in this case.

I hope it is not an issue for me to post this here, I just think that it would make more sense to do this way.

### Why no bug or feature request tag

There is no bug, everything works as described in the docs, and I don't think this is that important as it is not a feature just a miscellaneous edge case with icons.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。