9001 / 9001/copyparty

The NixOS module has multiple issues

Đang mở
#1,634 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
bug help wanted
Ngôn ngữ chính
Python
Star
46.6k
Fork
1.9k
Merge trung bình
10 ngày 16 giờ
Pull request đã merge (30 ngày)
5

Mô tả

### Describe the bug
As seen [here](https://github.com/9001/copyparty/blob/hovudstraum/contrib/nixos/modules/copyparty.nix#L121C7-L125C9), some settings are set by default, and notably a pretty important one, `hist`, that sets the cache dir location.

When the user change the settings, the values get overriden, thus breaks thumbnail generation because it then tries to write thumbnails into a .hist folder at the root of the volume, which copyparty needs write access to do so (not the case by default).

Additionally, the module sets some values, such as externalCacheDir or externalStateDir. Not only the user can't override these values, this also means that a user changing the location of `services.copyparty.settings.hist` wouldn't automatically add it to the `BindPaths` of the systemd service, so copyparty wouldn't have access to the folder.

There are probably more issues, this is what I quickly found after trying to find out why my thumbnails wouldn't generate.

### To Reproduce
Set `services.copyparty.settings` to anything, thumbnail generation breaks.
Set `services.copyparty.settings.hist` to anything other than `/var/cache/copyparty`, the systemd service doesn't bind mount that path.

### Expected behavior
The default values of these options should remain (but should be overridable), even if the user sets `services.copyparty.settings`, and the user should be able to change the cache and state directories, which are then reflected into the `config` block of the module.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.