5zig-reborn / 5zig-reborn/The-5zig-Mod

Issue with Name History Dialog typing in names with the keybind character in them

Open Beginner friendly
#150 1 comment 0 reactions 0 assignees View on GitHub
Bug
Dominant language
Java
Stars
111
Forks
12
PR merge metrics
No merged PRs in 30d

Description

When opening name history with a keybind and searching for a name, it will exit upon clicking that key again. For example, mapping Name History to N and then searching for `EvilMuffinHa` will exit when it hits the `n` in muffin.

**To Reproduce**
Steps to reproduce the behavior:
1. Map name history keybind to some character
2. Search for a name with that character in the dialog

**Expected behavior**
Expected it to print the letter without exiting, only exiting on `Esc`.

**Desktop (please complete the following information):**
- OS: Mac OS X
- Version 3.14.0

Contributor guide

No contributing guide indexed for this repository

Research direction

Look for the name history dialog UI code, likely in a GUI or keybind handling class. The issue is that the keybind character triggers dialog closure when typed during search. Find where key events are processed for the dialog and modify to ignore the bound key while the search field is focused, only closing on Esc. Test by mapping a keybind and searching for a name containing that character.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.