5zig-reborn / 5zig-reborn/The-5zig-Mod

Some chat settings won't apply

Đang mở
#133 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
Bug
Ngôn ngữ chính
Java
Star
111
Fork
12
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

**Describe the bug**
I see multiple bugs in the chat settings of the mod and second chat.

For example. The time stamp wont appear in the main chat, but it will in the second one.

The second chat size settings won't apply if they´re configured in the second chat tab, the second chat will take the settings of the main one configured in the original minecraft tab of chat settings.

And, what I consider the most important one: the Chat Limit. Chat limit wont apply it settings, no matter what, not even in the second chat

**To Reproduce**
Steps to reproduce the behavior:
1. Go to Options -> The 5 zig mod ->Display Options
2. Click on Chat Limit
3. See error

(This steps for chat limit only)

**Expected behavior**
Expected to see time stamp in both chats, configure second chat in its own tab and have the 1000 chat lines.

**Screenshots**
![image](https://user-images.githubusercontent.com/77423995/104539524-56f89180-55e3-11eb-8aef-4d8d6c1bb7ce.png)
This capture shows my chat limit settings

![image](https://user-images.githubusercontent.com/77423995/104539438-257fc600-55e3-11eb-8cbb-c482b62e2c4e.png)
As you can see in the top left of the chat, there is the limit of scrolleable. I have hours online so there must be more chat lines as configured in the mod

![image](https://user-images.githubusercontent.com/77423995/104539646-932bf200-55e3-11eb-977c-75e38828d817.png)
Time stamp enabled!

![image](https://user-images.githubusercontent.com/77423995/104539674-a17a0e00-55e3-11eb-992c-befb34e4f772.png)
But it is only showed in the second chat

**Desktop (please complete the following information):**
- OS: Windows 10
![image](https://user-images.githubusercontent.com/77423995/104539761-ca020800-55e3-11eb-9fc0-c1d5784a70ca.png)
- Version b251 Minecraft 1.16.4 fabric mod version
![image](https://user-images.githubusercontent.com/77423995/104539833-ed2cb780-55e3-11eb-8835-11f681f95bcf.png)

**Additional context**
None

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Hướng nghiên cứu

Look for chat-related configuration classes, likely in the display options module. The bug involves multiple chat settings (timestamp, size, chat limit) not applying correctly between main and second chat. Start by examining how chat settings are loaded and applied for each chat instance. Check for any UI configuration handlers and see if the second chat is incorrectly inheriting settings from the main chat. Running the mod in a development environment and testing changes to these settings will help verify the fix.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
java
Lĩnh vực
desktop, game-dev
Loại issue
Lỗi
Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức độ hoạt động
Đình trệ
Độ rõ ràng
Khá rõ ràng
Mức phù hợp với người mới
45/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.