5zig-reborn / 5zig-reborn/The-5zig-Mod

Oversaturation icons are buggy when entering and/or exiting water

Abierto
#121 3 comentarios 0 reacciones 0 asignados Ver en GitHub
Bug
Lenguaje dominante
Java
Estrellas
111
Forks
12
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Describe the bug**
This is mostly a visual bug and fixing of it is obviously not a high priority for me, so feel free to tackle this whenever.

The bug is, that the oversaturation disappears and reappears when entering and leaving a body of water.
This is (I assume) expected as the bubbles while swimming underwater appear on that exact position.
The problem with this is, that with the swim and water changes introduced in MC 1.13 was the disappearing of bubbles changed. Unlike before where it was instant will they now disappear after they have been refilled.
This causes the weird behaviour, where the bubbles show over the oversaturation icons as those are set to instantly reappear after you leave the water.

I have suggestions on how this could be fixed.

*1) Make the bubbles appear over the oversaturation*
If possible could you rearange the position of the bubbles to be over the new row of saturation.
This would obviously look a bit odd tho.

*2) New icon for oversaturation*
I personally would go for this one if feasible.
Just change the saturation icon of vanilla minecraft to a different one (Different outline or icon) when it is oversaturated, similar to what certain mods out there do (for other things than oversaturation).

**To Reproduce**
Steps to reproduce the behavior:
1. Have showing of oversaturation activated
2. Go into water
3. Swim around underwater
4. Go out of the water while bubbles are recharging

**Expected behavior**
The icons shouldn't overlap

**Screenshots**
![image](https://user-images.githubusercontent.com/11576465/98007373-9a6c9d80-1df3-11eb-8932-39d5ce2e1502.png)

**Desktop (please complete the following information):**
- OS: Windows 10
- Version: 1.16.3 b242

**Additional context**
As I mentioned at the beginning can this be treated as a low priority issue as it is only a minor visual issue and doesn't break the game in a bad way.
I just wanted to post this here to have it "logged" and not possibly lost in other places like Discord chat.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Look at the HUD rendering code for the oversaturation and bubble icons, likely in a class handling the in-game overlay. Understand how Minecraft 1.13+ changed bubble disappearance. Test by entering/exiting water with oversaturation enabled to see the overlap. Determine if repositioning icons or creating a new oversaturation icon is feasible within the mod's architecture.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
java
Área
game-dev
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.