5t3ph / 5t3ph/smolcss

Visited Style: float not removing underline in Firefox

Open Beginner friendly
#5 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Nunjucks
Stars
840
Forks
13
PR merge metrics
No merged PRs in 30d

Description

In the code-example you add `float: left` to the icon-`` to remove underline from it.
https://smolcss.dev/#smol-visited-styles

This is not working with (at least) recent Firefox (on Mac OS).

![screenshot from smolcss demo showing the unwanted underline under the icon](https://user-images.githubusercontent.com/1682719/120935036-313e6700-c701-11eb-8e6f-e0aa0567ec94.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue is in the 'Visited Style' demo at https://smolcss.dev/#smol-visited-styles. Look at the CSS for the icon span where `float: left` is applied to remove the underline. Test in Firefox on macOS to see the underline persists. Investigate alternative CSS properties like `display: inline-block` or `text-decoration-skip-ink` to fix the cross-browser issue. Check the project's CSS files for the demo snippet to make the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.