4paradigm / 4paradigm/OpenMLDB

feat(tools): refactor the use of `steps/ut.sh`

オープン
#984 コメント 0 件 リアクション 0 件 担当者 1 名 @aceforeverd が担当を希望しています GitHub で見る
enhancement
主要言語
C++
スター
1.7k
フォーク
331
平均マージ
12日 12時間
マージ済み PR(30日)
1

説明

**Is your feature request related to a problem? Please describe.**

#940

**Describe the solution you'd like**

The `steps/ut.sh` was used to run both unit test and integration test, it also start zookeeper at beginning and stop in the end.
But script is not stable and, not play well with coverage task, the cpp coverage test only pick tests that were added by `add_test` in CMakeLists.txt.

So the solution might be:
- [x] add unit tests with `add_test` in CMakeLists.txt, so they will be picked up directly by `make test`
- [ ] `steps/ut.sh` will use to run integration test only, and will setup zookeeper if not available. rename the script name
- [ ] unite start/stop zookeeper in one place, do not maintain different zookeeper up/down in different place. It might resolved in a standalone issue

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Look at the `steps/ut.sh` script and the CMakeLists.txt files to understand the current test structure. The goal is to separate unit tests (added via `add_test`) from integration tests. Check how zookeeper is started/stopped in different places and plan to consolidate it. Run `make test` to see which tests are currently picked up.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
cmake, cpp, shell
領域
build-system, testing-qa, tooling
issue の種類
リファクタリング
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
45/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。