4paradigm / 4paradigm/OpenMLDB

non-standard print style in `PlanNode::Print`

Open
#660 1 comment 0 reactions 1 assignee Claimed by @aceforeverd View on GitHub
enhancement execute-engine
Dominant language
C++
Stars
1.7k
Forks
331
Avg merge
12d 12h
Merged PRs (30d)
1

Description

Issue tracker is **ONLY** used for reporting bugs. New features should be discussed on our discussion

- `"\t"` instead of `INDENT` marco is used in some node's `Print` function
- in some node's implementation, indent is wrongly provided. e.g https://github.com/4paradigm/OpenMLDB/blob/main/hybridse/src/node/plan_node.cc#L386

## Expected Behavior

## Current Behavior

## Possible Solution

## Steps to Reproduce

1.
2.
3.
4.

## Context (Environment)

## Detailed Description

## Possible Implementation

Contributor guide

Open the contributing guide

Research direction

The issue points to a specific file, hybridse/src/node/plan_node.cc, line 386, where an indent is incorrectly provided. Look for other uses of '\t' instead of the INDENT macro in PlanNode::Print functions across the codebase. Start by examining the Print functions in plan_node.cc and related files to identify non-standard print styles. Ensure changes maintain consistent formatting.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.