4paradigm / 4paradigm/OpenMLDB

make `enable_distsql` defaults on

未关闭
#3,544 0 条评论 0 个 reaction 已指派 2 人 已被 @lqy222 认领 在 GitHub 查看
bug high-priority test
主要语言
C++
星标
1.7k
派生
331
平均合并
12 天 12 小时
30 天内合并 PR
1

描述

tablet server uses this flag `enable_distsql` to enable cluster optimization https://github.com/4paradigm/OpenMLDB/blob/b685e648e4467d86ce1ad8233b9428fb50313e09/src/tablet/tablet_impl.cc#L210-L214. It is on with release configurations: `release/conf/tablet.flags.template`, but no in `src/flags.cc`. Which as a results, won't enabled in mini_cluster tests, e.g `sql_sdk_test`.

There is a PR previously #3295, but turns out breaks existing tests. It means there exists cases that is OK with request mode, but not request(cluster) mode.

#3531 is a example, deployment tests not fail for those tests, simply because `enable_distsql` not turned on.

贡献指南

打开贡献指南

调研方向

The flag `enable_distsql` is defined in src/flags.cc and used in src/tablet/tablet_impl.cc lines 210-214. Check release/conf/tablet.flags.template for its default in release builds. Run mini_cluster tests like sql_sdk_test to see failures when the flag is enabled, as indicated by previous PR #3295. Investigate why certain tests pass in request mode but fail in request(cluster) mode, referencing issue #3531 as an example.

由索引模型根据 Issue 内容生成。

评估

技术栈
cpp
领域
backend, testing
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。