4paradigm / 4paradigm/OpenMLDB

make `enable_distsql` defaults on

Aperta
#3,544 0 commenti 0 reazioni 2 assegnatari Rivendicata da @lqy222 Vedi su GitHub
bug high-priority test
Lingua principale
C++
Stelle
1.7k
Fork
331
Merge medio
12g 12h
PR unite (30g)
1

Descrizione

tablet server uses this flag `enable_distsql` to enable cluster optimization https://github.com/4paradigm/OpenMLDB/blob/b685e648e4467d86ce1ad8233b9428fb50313e09/src/tablet/tablet_impl.cc#L210-L214. It is on with release configurations: `release/conf/tablet.flags.template`, but no in `src/flags.cc`. Which as a results, won't enabled in mini_cluster tests, e.g `sql_sdk_test`.

There is a PR previously #3295, but turns out breaks existing tests. It means there exists cases that is OK with request mode, but not request(cluster) mode.

#3531 is a example, deployment tests not fail for those tests, simply because `enable_distsql` not turned on.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.