4paradigm / 4paradigm/OpenMLDB

feat: refactor index option and move index option validation code to `SqlClusterRouter`

Open
#220 0 comments 0 reactions 1 assignee Claimed by @jingchen2222 View on GitHub
call-for-contributions enhancement
Dominant language
C++
Stars
1.7k
Forks
331
Avg merge
12d 12h
Merged PRs (30d)
1

Description

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Index key, ttl, ttl_type verify logic should be placed in `DB` or in `CORE`

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

1. Refeactor ColumnIndexNode. We only keep general structure.
2. Move `ttl`, `ttl_type`, `verson` logic to `OPENMLDB`
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

Research direction

Look at the ColumnIndexNode structure and the SqlClusterRouter class to understand the current index option validation logic. Determine which parts are general and which are specific to OPENMLDB. Move ttl, ttl_type, and version validation to the appropriate location, ensuring the refactored code maintains functionality.

Written by the indexing model from the issue text.

Assessment

Domain
database, machine-learning
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.