4paradigm / 4paradigm/OpenMLDB
merge aggregators in `src/storage/aggregator.xx` and `hybridse/src/vm/aggregator.h`
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 331
- Avg merge
- 12d 12h
- Merged PRs (30d)
- 1
Description
**Describe the feature you'd like**
There are two different places to implement the pre-aggregation logics for the `long window` feature. We should finally merge these in order to avoid code duplication.
Contributor guide
Research direction
The issue mentions merging aggregators in `src/storage/aggregator.xx` and `hybridse/src/vm/aggregator.h`. First, examine these two files to understand the pre-aggregation logic for the 'long window' feature. Look for overlapping code and design a unified implementation. Check for existing tests related to aggregators to ensure the merge does not break functionality. The goal is to eliminate duplication while maintaining the same behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100