4paradigm / 4paradigm/OpenMLDB
build: compile with more strict flags
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 331
- Avg merge
- 12d 12h
- Merged PRs (30d)
- 1
Description
**Describe the feature you'd like**
It appear there are many warnings during compilation. To improve code quality, we should consider just failing the compile when some of the warnings meet, not limited to e.g:
- -Wdangling-gsl
- -Wformat
- -Wdelete-non-abstract-non-virtual-dtor
- -Wthread-safety
**Additional context**
Add any other context or screenshots about the feature request here.
Contributor guide
Research direction
Look at the project's build configuration files (CMakeLists.txt, Makefile, or similar) to see current compiler flags. Research each suggested warning flag (-Wdangling-gsl, -Wformat, -Wdelete-non-abstract-non-virtual-dtor, -Wthread-safety) for compatibility with the codebase. Test compilation with these flags enabled to identify and understand the warnings, then decide which to promote to errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100