4paradigm / 4paradigm/OpenMLDB

feat(ResultSetBuilder): construct `ResultSet` directly from client, support all basic data type

Abierto
#1,456 0 comentarios 0 reacciones 0 asignados Ver en GitHub
call-for-contributions enhancement
Lenguaje dominante
C++
Estrellas
1.7k
Forks
331
Merge medio
12 d 12 h
PR fusionados (30 d)
1

Descripción

**Is your feature request related to a problem? Please describe.**

There are three ways to construct a `ResultSet`, https://github.com/4paradigm/OpenMLDB/blob/420398b8349880bce262db06c3b143d023b56862/src/sdk/result_set_sql.h#L45-L56, the first two approach rely on protobuf structures, and the third approach assume all fields as string.

So there is no ease way to construct a `ResultSet` from scratch. E.g. I'd like to construct a `ResultSet` with the schema of `id int, buf string, ts timestamp`, and assert result set data in unit tests.

**Describe the solution you'd like**

TBD

An example (may not accurate):
```cpp
ResultSetBuilder()
.schema(schema)
.data(rows)
.build();
```

**other context**

hybridse's test use `Row` to assert test results: https://github.com/4paradigm/OpenMLDB/blob/420398b8349880bce262db06c3b143d023b56862/hybridse/include/codec/row.h#L36-L38. Let's see if we can reuse few or more

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Review the existing ResultSet constructors in src/sdk/result_set_sql.h and the Row class in hybridse/include/codec/row.h. Understand the schema representation and data types (int, string, timestamp). Design a builder API that can create a ResultSet directly from a schema and rows of data, then implement it in the C++ SDK.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
cpp
Área
database, testing
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.