4paradigm / 4paradigm/OpenMLDB
Feat: some functions in disktable need to be implemented
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 331
- Avg merge
- 12d 12h
- Merged PRs (30d)
- 1
Description
These functions are already implemented in memtable and tested in table_test. They should be implemented in disktable. After implementing them, tests in table_test need to be updated.
``` cpp
bool DiskTable::DeleteIndex(const std::string& idx_name)
uint64_t DiskTable::GetRecordIdxCnt()
bool DiskTable::GetRecordIdxCnt(uint32_t idx, uint64_t** stat, uint32_t* size)
uint64_t DiskTable::GetRecordPkCnt()
uint64_t DiskTable::GetRecordIdxByteSize() {
uint64_t DiskTable::Release()
```
Contributor guide
Research direction
The issue points to functions in disktable that need implementation, referencing existing implementations in memtable and tests in table_test. Start by examining the memtable implementations to understand the expected behavior, then locate the disktable source files. Update the tests in table_test to verify the new implementations. The work involves C++ database internals and requires navigating the codebase to understand the table abstraction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100