4drian3d / 4drian3d/SignedVelocity

Detect the need and implement handling for legacy AsyncPlayerChatEvent

オープン
#151 コメント 0 件 リアクション 2 件 担当者 0 名 GitHub で見る
wontfix
主要言語
Java
スター
73
フォーク
23
平均マージ
11時間 19分
マージ済み PR(30日)
9

説明

SignedVelocity has first-class support for AsyncChatEvent, which is fantastic. However, for multiple reasons, it should support `AsyncPlayerChatEvent`, and not just in a separate (and unmaintained) repository like https://github.com/4drian3d/SignedVelocity-Legacy.

### Proposal
SignedVelocity could easily check `AsyncPlayerChatEvent.getHandlerList()` to see if there are any listeners, and if so, add handling for this event. If I remember correctly, the AsyncPlayerChatEvent happens first. Thus, existing logic and data could be re-used, except that SignedVelocity could perform a "peek" on the data queue while listening to it (whereas standard "poll" is reserved for AsyncChatEvent).

If you want to discourage usage of `AsyncPlayerChatEvent`, which is certainly a worthy goal, this could also be an opportunity to print a warning message.

### Motivation
Besides it being already difficult to debug chat cancelation across plugins, SignedVelocity introduces another complication. By forgoing to implement the AsyncPlayerChatEvent in the main repository, SignedVelocity causes unexpected behavior when interacting with established or aged chat plugins. This plugin is advertised on Modrinth as transmitting chat event behavior to the backend servers, but if there are cases where that fails, then SignedVelocity starts to fail in its stated objective.

AsyncPlayerChatEvent may be deprecated. However, it is still supported API, and it is a go-to for plugins that want to run on Spigot. We may see plugins continue to use this event for several years, and I don't think SignedVelocity is in a good position to push everyone toward Paper & `AsyncChatEvent` - at least not instantly, which is why I suggested a warning message.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

Look at the existing AsyncChatEvent handling in the codebase, likely in a main plugin class. Find where event listeners are registered and data queues are managed. Check AsyncPlayerChatEvent.getHandlerList() to understand listener detection. The change involves adding conditional logic, possibly a 'peek' operation on the queue, and a warning message. Test with plugins that use the legacy event.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
java
領域
api, backend
issue の種類
機能追加
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
45/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。