43081j / 43081j/postcss-styled-components

Autofix generates invalid code with nested style blocks

Open
#9 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
12
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Test case 1:

```tsx
const Div = styled.div`
${css`
color: blue;
`}
`;
```

This code yields the error `Skipping template… as it included either invalid syntax or complex expressions the plugin could not interpret`, as described at #7.

Test case 2:

```tsx
const Div = styled.div`
${css`
color: blue;
`}

div {
position: absolute;
}
`;
```

This yields the error `Unexpected unknown type selector "POSTCSS_styled-components_0" (selector-type-no-unknown)` on the `${}` line. But what's really strange is what happens if you run stylelint with `--fix`. The output is this invalid code:

```tsx
const Div = styled.div`
${css`
color: blue;
`}

div {
position: absolute;
}
color: blue;
`}

div {
position: absolute;
}
`;
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Look at the parser in src/syntax.js and the transformer in src/transformer.js. The bug occurs when nested template literals with css blocks are processed. Start by reproducing the error with the given test cases, then trace how the plugin handles interpolation and nested style blocks. Check the output after autofix to see where duplication happens.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.