404labfr / 404labfr/laravel-impersonate

Redirect to URL where the Impersonation was triggered not working

Open
#230 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.3k
Forks
235
PR merge metrics
No merged PRs in 30d

Description

Firstly, thanks for the great plugin.
Unfortunately I found a bug, where the leave method doesn't redirect to the page as intended:

````

if (session()->has('laravel-impersonate:leave_redirect_to')) {
$routeName = session('laravel-impersonate:leave_redirect_to');
session()->forget('laravel-impersonate:leave_redirect_to');
}
````
The above code is great, but it appears that the session parameter has never been set.

I'm creating a pull request to fix that issue and will refer this issue to it. Please merge in a timely manner, so I don't have to implement my fork into production.

Thanks in advance. PR coming soon

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.