404labfr / 404labfr/laravel-impersonate

Wrong PHPDoc type for id (int instead of int|string or mixed) causes PHPStan errors

Open
#228 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.3k
Forks
235
PR merge metrics
No merged PRs in 30d

Description

**Description:**
In the code, the PHPDoc for `id` is hardcoded as `int`.
Since our project also uses UUIDs as IDs, this results in PHPStan errors.

**Example:**
https://github.com/404labfr/laravel-impersonate/blob/5033f3433a55ca8bb2cc3e4a018a39dd8a327a9f/src/Services/ImpersonateManager.php#L28C15-L28C19

**Expected behavior:**
The PHPDoc type should allow UUIDs (e.g. `string|int` or a more suitable type) so PHPStan does not report errors. Laravel uses the type `mixed`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.