404labfr / 404labfr/laravel-impersonate

Error display text in other language not english.

未關閉
#213 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
PHP
星號
2.3k
分支
235
PR 合併指標
30 天內沒有已合併 PR

描述

## Bug Description
When using a non-English locale, the impersonation banner shows raw translation keys instead of the translated text:

Current display:
`filament-impersonate::banner.impersonating Nguyễn Khánh Thu filament-impersonate::banner.leave`

Expected display:
`Đang giả lập người dùng Nguyễn Khánh Thu Kết thúc giả lập`

## Steps to Reproduce
1. Set application locale to non-English (e.g. Vietnamese 'vi')
2. Implement impersonation feature
3. Start impersonating a user
4. Observe the banner text

## Current Workaround Attempts
- Created translation files in various locations:
- `lang/vendor/filament-impersonate/vi/translations.php`
- `lang/vendor/filament-impersonate/vi/banner.php`
- `lang/vi/filament-impersonate.php`
- None of above solutions worked, still showing raw translation keys

## Suggested Solutions
1. Add proper documentation for translation structure
2. Provide publishable language files:
```php artisan vendor:publish --tag=filament-impersonate-translations```
3. Include example translation files in the package

## Environment
- Laravel version: 11.x
- Filament v3
- PHP version: 8.2
- Package version: latest
- Locale: vi

Screenshots attached:
![image](https://github.com/user-attachments/assets/198edfd7-b192-4ca6-9f55-9e6fbd2a5737)

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。