404labfr / 404labfr/laravel-impersonate

Missing remember me

Open
#208 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.3k
Forks
235
PR merge metrics
No merged PRs in 30d

Description

Hello, the notion of remember_me is missing in the Session Guard of the plugin, which causes the user to be disconnected when leaving a spoof. Laravel adds it in its core...

Would it be possible to add these 2 lines in the Guard/SessionGuard.php file, in the quietLogin method between updateSession and setUser ?

```
/**
* Log a user into the application without firing the Login event.
*
* @param \Illuminate\Contracts\Auth\Authenticatable $user
* @return void
*/
public function quietLogin(Authenticatable $user)
{
$this->updateSession($user->getAuthIdentifier());

$this->ensureRememberTokenIsSet($user); // New line here
$this->queueRecallerCookie($user); // New line here

$this->setUser($user);
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.