2072 / 2072/vim-syntax-for-PHP

oddities with shorttag off

Open
#6 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Vim Script
Stars
16
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Found this by accident, after disabling shorttags parsing after working a rather large file that caused syntax parsing to take a few seconds...

shorttags not disabled (that is, the default)

![image](https://github.com/2072/vim-syntax-for-PHP/assets/56283/562a0f1d-faaa-49d3-8dbe-994109422dbb)
(note that these are not short tags, but echo tags)

with `php_noShortTags=1`
![image](https://github.com/2072/vim-syntax-for-PHP/assets/56283/8cbad772-2e38-474d-9669-e359855d4f86)

with `php_noShortTags=1`, if I remove the `` be on a line with code (doesn't have to be a single line with the opening `` closing on its own line. Only after i save and quit and reopen the file (or save and `:e!`). Likewise if i open a file with the bug, removing the trigger won't fix it, until I reload the file. Whatever is causing it is "sticky".

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue is in the Vim syntax file for PHP, likely in syntax/php.vim. Start by examining how shorttags are toggled with php_noShortTags and how regions for and echo tags are defined. Reproduce the bug with the provided examples to see the sticky highlighting behavior. Look for syntax region definitions that might incorrectly nest or fail to reset when the closing tag is on its own line.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, vim
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.