1rosehip / 1rosehip/jplist

CSS might be improveable

Open
#252 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
435
Forks
168
PR merge metrics
No merged PRs in 30d

Description

Hi, please regard this as a mix of a feature request and feedback. I did not find another issue that mentions it.

Like mentioned in my other feature request, jplist impressed me. But I had some issues with the CSS, and wanted to share that pain point. Those were mine:

1. The css assumes a specific naming for the panel class, despite the panel class being configurable
1. Some of the controls assume a css file, but don't present it on the download list. I fetched those from their example page.
1. The .lato class seems strange to me, that just won't work in most proejcts
1. The float: left approach did not work for me, as it fails to resize the container when the page gets too small. I replace that with inline-block, but it could also work well with flexbox.
1. Since I had to modify the code, it would have been easier for me if the download page would not link the minimized files but the original sources, at least additionally.

I can share the modifications I did, if you are interested. Not generic enough for a PR, but maybe enough to give an idea what improvements might be possible.

In any case, keep up the good work ❤️

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the CSS files in the repository, particularly those related to panel classes and controls. Check the download page configuration to see how CSS files are linked. Examine the .lato class and float: left usage in the codebase. The goal is to make CSS more flexible and provide original source files for easier modification.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, jquery
Domain
frontend, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.