1rosehip / 1rosehip/jplist

CSS might be improveable

Aberta
#252 0 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
HTML
Estrelas
435
Forks
168
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Hi, please regard this as a mix of a feature request and feedback. I did not find another issue that mentions it.

Like mentioned in my other feature request, jplist impressed me. But I had some issues with the CSS, and wanted to share that pain point. Those were mine:

1. The css assumes a specific naming for the panel class, despite the panel class being configurable
1. Some of the controls assume a css file, but don't present it on the download list. I fetched those from their example page.
1. The .lato class seems strange to me, that just won't work in most proejcts
1. The float: left approach did not work for me, as it fails to resize the container when the page gets too small. I replace that with inline-block, but it could also work well with flexbox.
1. Since I had to modify the code, it would have been easier for me if the download page would not link the minimized files but the original sources, at least additionally.

I can share the modifications I did, if you are interested. Not generic enough for a PR, but maybe enough to give an idea what improvements might be possible.

In any case, keep up the good work ❤️

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Direção de pesquisa

Review the CSS files in the repository, particularly those related to panel classes and controls. Check the download page configuration to see how CSS files are linked. Examine the .lato class and float: left usage in the codebase. The goal is to make CSS more flexible and provide original source files for easier modification.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
css, jquery
Domínio
frontend, tooling
Tipo de issue
Funcionalidade
Dificuldade
3/5
Tempo estimado
1-2 dias
Status de atividade
Estagnada
Clareza
Razoavelmente clara
Facilidade para iniciantes
45/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.