1adrianb / 1adrianb/face-alignment
[Contribution suggestion] Allow explicitly passing in model_dir
- 主要言語
- Python
- スター
- 7.5k
- フォーク
- 1.4k
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
Hi @1adrianb
Lovely package, first of all. I was testing it, and ran into (and have resolved in a fork) an issue with deploying to AWS Lambda:
* AWS Lambda only allows IO writes to the /tmp/ directory namespace
* The current package defaults to the `get_dir` from torch.hub which is not within that namespace
* Result: No models run on AWS Lambda from what I can deduce
Fix/enhancement (easy): Add `model_dir: str = None` to each of the `__init__` for classes that use torch URL-loading functions. Downstream functions already support the explicit model_dir, but top-level class initialization e.g. in `api.py` module doesn't.
If you agree, I am happy to send you a PR on it:)
Best, Thoger.
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
The issue points to the `api.py` module where class `__init__` methods need a `model_dir` parameter. Start by examining the torch.hub loading calls in those classes. The downstream functions already support `model_dir`, so trace where the model is loaded and ensure the parameter is passed through. Test by running a simple inference to verify models can be loaded from a custom directory like /tmp.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- python, pytorch
- 領域
- backend, cloud
- issue の種類
- 機能追加
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 活発さ
- 停滞
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 70/100