1602 / 1602/jugglingdb

callback of AbstractClass.include may be executed several times

Aperta
#414 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
2k
Fork
238
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

/lib/include.js line 25: `AbstractClass.include = function (objects, include, cb) {`
If objects length is 0, and include is an array with multiple items, the cb will be executed several times.
While integrating with Express, this will cause the known issue "Can't set headers after they are sent."

To fix it, my suggestion is to add "return" before cb in line 53 as: `return cb(null, objects);`

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

The issue points to /lib/include.js line 25 and line 53. Start by examining the AbstractClass.include function to understand the loop logic. Check the condition when objects length is 0 and include is an array with multiple items. The fix suggested is to add a return statement before the callback. Test the change by running any existing tests related to include functionality or by creating a simple script to reproduce the callback being executed multiple times.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript, node.js
Ambito
backend, databases
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.