0xSpaceShard / 0xSpaceShard/starknet-hardhat-example

Improve checks in CI/CD

Abierto
#116 0 comentarios 0 reacciones 1 asignado Reclamado por @Nathan-SL Ver en GitHub
enhancement
Lenguaje dominante
TypeScript
Estrellas
88
Forks
29
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Currently we just lint, but we would benefit from doing what I have in my pre-commit script:
```bash
set -e

# check typescript correctness
npx tsc --noEmit

# check all .sh files are executable
invalid_scripts=0
for script in $( find . -type f -iname *.sh ); do
if [ ! -x $script ]; then
echo "Script $script is not executable"
invalid_scripts=$((invalid_scripts + 1))
fi
done
if [ $invalid_scripts != 0 ]; then
exit 1
fi

# check there are no it.only occurrences in the tests
grep -re "it\.only(" $(git ls-files '*.ts') && echo "Error: There are files with it.only(...)" && exit 2

# lint
npm run lint
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Look for the CI/CD configuration file (likely .github/workflows/*.yml) to understand the current linting step. The issue provides a bash script to integrate: it runs TypeScript type checking, ensures .sh files are executable, checks for stray it.only in test files, and then runs linting. Start by locating where the CI script runs and add these checks in the appropriate order. Verify by running the script locally and then updating the CI configuration.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
bash, github-actions, nodejs, shell, typescript
Área
ci-cd, testing, tooling
Tipo de issue
Nueva funcionalidad
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
40/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.