0xSpaceShard / 0xSpaceShard/starknet-hardhat-example

Improve checks in CI/CD

未关闭
#116 0 条评论 0 个 reaction 已指派 1 人 已被 @Nathan-SL 认领 在 GitHub 查看
enhancement
主要语言
TypeScript
星标
88
派生
29
PR 合并指标
30 天内没有已合并 PR

描述

Currently we just lint, but we would benefit from doing what I have in my pre-commit script:
```bash
set -e

# check typescript correctness
npx tsc --noEmit

# check all .sh files are executable
invalid_scripts=0
for script in $( find . -type f -iname *.sh ); do
if [ ! -x $script ]; then
echo "Script $script is not executable"
invalid_scripts=$((invalid_scripts + 1))
fi
done
if [ $invalid_scripts != 0 ]; then
exit 1
fi

# check there are no it.only occurrences in the tests
grep -re "it\.only(" $(git ls-files '*.ts') && echo "Error: There are files with it.only(...)" && exit 2

# lint
npm run lint
```

贡献指南

这个仓库没有索引到贡献指南

调研方向

Look for the CI/CD configuration file (likely .github/workflows/*.yml) to understand the current linting step. The issue provides a bash script to integrate: it runs TypeScript type checking, ensures .sh files are executable, checks for stray it.only in test files, and then runs linting. Start by locating where the CI script runs and add these checks in the appropriate order. Verify by running the script locally and then updating the CI configuration.

由索引模型根据 Issue 内容生成。

评估

技术栈
bash, github-actions, nodejs, shell, typescript
领域
ci-cd, testing, tooling
Issue 类型
功能
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
40/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。