0xMiden / 0xMiden/wallet

Remove the retired native navbar bridge and platform overlays

未關閉
#809 0 則留言 0 個 reaction 已指派 1 人 已被 @BrianSeong99 認領 在 GitHub 檢視
enhancement Mobile Wallet
主要語言
TypeScript
星號
5
分支
28
平均合併
9 小時 50 分鐘
30 天內合併 PR
123

描述

## Problem

Commit `5fd95811` retired the JavaScript side of the native mobile navbar and moved the persistent wallet navigation to React `BottomNav`. The Swift and Android overlay implementations, plugin methods, events, resources, and dApp-dialog integration remain compiled in the repository, but no live wallet source calls them.

Keeping this unreachable implementation creates maintenance work and makes the current architecture difficult to determine. PR #807 exposed this by fixing an Android four-item layout bug in code that cannot currently render.

## Scope

- Remove the native-navbar plugin API and event surface from the bundled dApp-browser package.
- Remove the iOS overlay window and navbar-specific controls.
- Remove the Android navbar manager, views, state classes, drawables, colors, and dialog/activity integration.
- Remove generated declarations or documentation that expose the retired API.
- Keep the native dApp WebView behavior unchanged.

## Acceptance criteria

- [ ] No callable native-navbar methods or events remain in the dApp-browser plugin.
- [ ] No native navbar view is compiled into the iOS or Android app.
- [ ] Opening, switching, and closing embedded dApps continues to work.
- [ ] React `BottomNav` remains the only persistent wallet navigation implementation.
- [ ] Relevant package builds, wallet type checks, and targeted tests pass.
- [ ] `git diff --check` passes.

Found while validating #802 in PR #807.

貢獻指南

開啟貢獻指南

研究方向

Start by locating the dApp-browser plugin to remove the native-navbar API and events. Then find the iOS overlay window and Android navbar manager, views, and related resources. Verify that React BottomNav remains the only navigation by building the packages and running targeted tests. Ensure embedded dApp WebView behavior is unchanged after removal.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
android, swift, typescript
領域
backend-api-design, frontend, mobile
Issue 類型
重構
難度
3/5
預估耗時
1-2 天
活躍度
活躍
描述清晰度
描述清楚
新手友好度
55/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。