0xMiden / 0xMiden/wallet

Correct stale guidance about mobile navbar ownership

Đang mở Phù hợp với người mới
#808 0 bình luận 0 reaction 1 người được giao Được @BrianSeong99 nhận Xem trên GitHub
documentation
Ngôn ngữ chính
TypeScript
Star
5
Fork
28
Merge trung bình
9 giờ 50 phút
Pull request đã merge (30 ngày)
123

Mô tả

## Problem

The wallet has rendered its persistent bottom navigation through the React `BottomNav` since commit `5fd95811`, including in the Capacitor mobile app. However, `AGENTS.md`, `CLAUDE.md`, and the shared frontend skill still describe the retired Swift/Android navbar overlay as the active mobile implementation.

That stale guidance already affected issue #802 by asking contributors to update both a native navbar and a React footer even though only the React path is reachable.

## Scope

- Update `AGENTS.md` and `CLAUDE.md` to describe the current React-owned navigation architecture.
- Remove references to the deleted `DappBrowserProvider` navbar wiring and `use-native-navbar-action` test hook.
- Update `skills/miden-wallet-frontend/` so its platform and verification guidance points contributors to `BottomNav`, `TabLayout`, safe-area behavior, and mobile interaction requirements.
- Preserve historical changelog entries as historical records.
- Keep the canonical skill and both agent links consistent.

## Acceptance criteria

- [ ] Current repository instructions no longer claim that the mobile navbar is a native overlay.
- [ ] The frontend skill identifies React `BottomNav` as the shared navbar across extension, mobile, and desktop.
- [ ] Guidance still covers mobile safe areas, haptics, and platform-specific verification.
- [ ] No current instruction references deleted navbar wiring or hooks.
- [ ] Skill validation and `git diff --check` pass.

Found while validating #802 in PR #807.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Hướng nghiên cứu

Start by reading the files mentioned: AGENTS.md, CLAUDE.md, and the frontend skill in skills/miden-wallet-frontend/. Look at the React BottomNav component to understand the current navigation architecture. Remove references to the old native navbar and DappBrowserProvider. Ensure the updated documentation consistently describes the React-owned navigation and covers mobile-specific requirements like safe areas and haptics. Run skill validation and `git diff --check` to confirm the changes are correct.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
react, typescript
Lĩnh vực
documentation, mobile-dev
Loại issue
Tài liệu
Độ khó
2/5
Thời gian dự kiến
1-3 giờ
Mức độ hoạt động
Sôi nổi
Độ rõ ràng
Đặc tả rõ ràng
Mức phù hợp với người mới
75/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.