0xMiden / 0xMiden/wallet

Re-enable guardian E2E on web-sdk 0.16 once OZ ships a protocol-0.16 multisig/guardian client

Aberta Para iniciantes
#522 0 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
TypeScript
Estrelas
5
Forks
28
Merge médio
9h 50min
PRs com merge (30d)
123

Descrição

## Context

The `next` branch is migrating to web-sdk 0.16 (PR #521). Guardian account **creation** fails on SDK 0.16 with a MASM link error:

```
Error creating Guardian account: script builder: failed to link module
openzeppelin::auth::guardian_ecdsa … undefined constant 'AUTH_UNAUTHORIZED_EVENT'
```

### Root cause
`@openzeppelin/miden-multisig-client` has **no release built against miden-protocol 0.16**. The latest (`0.16.1`) still depends on `@miden-sdk/miden-sdk@^0.15.8`; its `guardian_ecdsa` MASM references `AUTH_UNAUTHORIZED_EVENT`, a 0.15-era auth constant removed/renamed in protocol 0.16.0-alpha.4. OZ's `0.16.x` version tracks their own client, not miden-protocol 0.16.

This breaks guardian in the **product** on 0.16, not only in E2E. A client-only MASM patch is not viable (co-sign ABI must match across client + guardian server + on-chain verification).

### Quarantined on #521 (re-enable when OZ ships a protocol-0.16 client)
- [ ] `pr-e2e-bridge-guardian.yml` — remove the job-level `if: false` guard
- [ ] `pr-e2e-guardian-lifecycle.yml` — remove the job-level `if: false` guard
- [ ] `playwright.swap.config.ts` — remove the `testIgnore` for `swap-guardian.spec.ts`
- [ ] Revert both guardian gates to require `success` only (drop the `skipped` tolerance)
- [ ] Bump `@openzeppelin/miden-multisig-client` + `@openzeppelin/guardian-client` to the protocol-0.16 release; bump `GUARDIAN_IMAGE_TAG` to the matching server image

Non-guardian E2E (local, earn, swap non-guardian) is green on 0.16.

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

The issue is blocked on an external dependency update from OpenZeppelin. To prepare, locate the CI configuration files mentioned: `pr-e2e-bridge-guardian.yml`, `pr-e2e-guardian-lifecycle.yml`, and `playwright.swap.config.ts`. Find the `testIgnore` for `swap-guardian.spec.ts` and the job-level `if: false` guards. Once OpenZeppelin releases a protocol-0.16 compatible client, update the package versions and image tag as listed, then remove the guards to re-enable the tests.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
javascript, nodejs, typescript
Domínio
backend, devops, testing
Tipo de issue
Bug
Dificuldade
2/5
Tempo estimado
1-3 horas
Status de atividade
Pouca atividade
Clareza
Claramente especificada
Facilidade para iniciantes
65/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.